pgsql: Fix thinko in nocachegetattr() and nocache_index_getattr()

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix thinko in nocachegetattr() and nocache_index_getattr()
Date: 2026-03-16 20:01:01
Message-ID: E1w2E7Y-0003nK-2J@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix thinko in nocachegetattr() and nocache_index_getattr()

This code was recently adjusted by c456e3911, but that commit didn't get
the logic correct when finding the attnum to start walking the tuple in.
If there is a NULL, we need to start walking the tuple before it.

Author: David Rowley <dgrowleyml(at)gmail(dot)com>
Reported-by: Tender Wang <tndrwang(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAHewXNnb-s_=VdVUZ9h7dPA0u3hxV8x2aU3obZytnqQZ_MiROA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7a2ab122a1c555ee4298863917ce68a2b9800cb8

Modified Files
--------------
src/backend/access/common/heaptuple.c | 9 +++++----
src/backend/access/common/indextuple.c | 9 +++++----
2 files changed, 10 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Jeff Davis 2026-03-16 20:44:22 pgsql: Clean up postgres_fdw/t/010_subscription.pl.
Previous Message Robert Haas 2026-03-16 19:14:54 pgsql: pg_plan_advice: Fix failures to accept identifier keywords.