pgsql: pg_plan_advice: Fix failures to accept identifier keywords.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_plan_advice: Fix failures to accept identifier keywords.
Date: 2026-03-16 19:14:54
Message-ID: E1w2DOv-0003PG-1s@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_plan_advice: Fix failures to accept identifier keywords.

TOK_IDENT allows only non-keywords; identifier should be used
any place where either keywords or non-keywords should be accepted.
Hence, without this commit, any string that happens to be a keyword
can't be used as a partition schema, partition name, or plan name,
which is incorrect.

Author: Lukas Fittl <lukas(at)fittl(dot)com>
Discussion: http://postgr.es/m/CAP53PkzKeD=t90OfeMsniYrcRe2THQbUx3g6wV17Y=ZtiwmWTQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5e72ce2467c15340026955b57ff75f75e853a766

Modified Files
--------------
contrib/pg_plan_advice/expected/syntax.out | 45 ++++++++++++++++++++++++++++++
contrib/pg_plan_advice/pgpa_parser.y | 6 ++--
contrib/pg_plan_advice/sql/syntax.sql | 19 +++++++++++++
3 files changed, 67 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2026-03-16 20:01:01 pgsql: Fix thinko in nocachegetattr() and nocache_index_getattr()
Previous Message Peter Eisentraut 2026-03-16 18:38:09 pgsql: Fix whitespace