pgsql: pg_recvlogical: remove unnecessary OutputFsync() return value ch

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_recvlogical: remove unnecessary OutputFsync() return value ch
Date: 2026-01-16 03:39:58
Message-ID: E1vgagn-000jfu-31@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_recvlogical: remove unnecessary OutputFsync() return value checks.

Commit 1e2fddfa33d changed OutputFsync() so that it always returns true.
However, pg_recvlogical.c still contained checks of its boolean return
value, which are now redundant.

This commit removes those checks and changes the type of return value of
OutputFsync() to void, simplifying the code.

Suggested-by: Yilin Zhang <jiezhilove(at)126(dot)com>
Author: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Reviewed-by: Mircea Cadariu <cadariu(dot)mircea(at)gmail(dot)com>
Reviewed-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAHGQGwFeTymZQ7RLvMU6WuDGar8bUQCazg=VOfA-9GeBkg-FzA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b98cc4a14e538d0bc139f50606249b99cc9215cd

Modified Files
--------------
src/bin/pg_basebackup/pg_recvlogical.c | 23 +++++++----------------
1 file changed, 7 insertions(+), 16 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Langote 2026-01-16 04:26:00 pgsql: Fix segfault from releasing locks in detached DSM segments
Previous Message Michael Paquier 2026-01-16 03:13:21 pgsql: Fix stability issue with new TAP test of pg_createsubscriber