pgsql: Fix stability issue with new TAP test of pg_createsubscriber

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix stability issue with new TAP test of pg_createsubscriber
Date: 2026-01-16 03:13:21
Message-ID: E1vgaH2-000jLd-12@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix stability issue with new TAP test of pg_createsubscriber

The test introduced in 639352d904c8 has added a direct pg_ctl command to
start a node, a method that is incompatible with the teardown() routine
used at the end of the test as the PID saved in the Cluster object would
prevent the node to be shut down. This can ultimately prevent the test
to perform its cleanup, failing on timeout.

Like pg_ctl's 001_start_stop or ssl_passphrase_callback's 001_testfunc,
this commit changes the test so a direct pg_ctl command is used to stop
the rogue node. That should be hopefully enough to cool down the
buildfarm.

Per report from buildfarm member fairywren, which is the only animal
that is showing this issue.

Author: Hayato Kuroda <kuroda(dot)hayato(at)fujitsu(dot)com>
Discussion: https://postgr.es/m/TY7PR01MB1455452AE9053DD2B77B74FEAF58CA@TY7PR01MB14554.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a7c63e486050636925f81123b1427f1cb49644a2

Modified Files
--------------
src/bin/pg_basebackup/t/040_pg_createsubscriber.pl | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2026-01-16 03:39:58 pgsql: pg_recvlogical: remove unnecessary OutputFsync() return value ch
Previous Message Michael Paquier 2026-01-15 23:15:26 pgsql: Add pg_clear_extended_stats()