pgsql: Add comment about keeping PD_ALL_VISIBLE and VM in sync

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add comment about keeping PD_ALL_VISIBLE and VM in sync
Date: 2025-12-10 16:32:43
Message-ID: E1vTN7K-0000RR-1q@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add comment about keeping PD_ALL_VISIBLE and VM in sync

The comment above heap_xlog_visible() about the critical integrity
requirement for PD_ALL_VISIBLE and the visibility map should also be in
heap_xlog_prune_freeze() where we set PD_ALL_VISIBLE.

Oversight in add323da40a6bf9e

Author: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Discussion: https://postgr.es/m/flat/CAAKRu_ZMw6Npd_qm2KM%2BFwQ3cMOMx1Dh3VMhp8-V7SOLxdK9-g%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/eebec3ca4b5ef13d01837966f51b391143670131

Modified Files
--------------
src/backend/access/heap/heapam_xlog.c | 6 ++++++
1 file changed, 6 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2025-12-10 17:32:12 pgsql: Improve DDL deparsing test
Previous Message Heikki Linnakangas 2025-12-10 13:35:02 pgsql: Fix comment in GetPublicationRelations