| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Improve DDL deparsing test |
| Date: | 2025-12-10 17:32:12 |
| Message-ID: | E1vTO2t-0000ld-0Y@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Improve DDL deparsing test
1. The test initially focuses on the "parent" table, then switches to
the "part" table, and goes back to the "parent" table. That seems a
little weird, so move the tests around so that all the commands on the
"parent" table are done first, followed by the "part" table.
2. ALTER TABLE ALTER COLUMN SET EXPRESSION was not tested, so add
that.
Author: jian he <jian(dot)universality(at)gmail(dot)com>
Reviewed-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/CACJufxFDi7fnwB-8xXd_ExML7-7pKbTaK4j46AJ=4-14DXvtVg@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/343693c3c116688970be550fcbf15f7ddf55525b
Modified Files
--------------
.../test_ddl_deparse/expected/alter_table.out | 41 ++++++++++++----------
.../modules/test_ddl_deparse/sql/alter_table.sql | 27 +++++++-------
2 files changed, 36 insertions(+), 32 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2025-12-10 17:58:51 | pgsql: Fix bogus extra arguments to query_safe in test |
| Previous Message | Melanie Plageman | 2025-12-10 16:32:43 | pgsql: Simplify vacuum visibility assertion |