pgsql: Teach DSM registry to retry entry initialization if needed.

From: Nathan Bossart <nathan(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Teach DSM registry to retry entry initialization if needed.
Date: 2025-11-26 21:16:04
Message-ID: E1vOMrr-001YSX-28@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Teach DSM registry to retry entry initialization if needed.

If DSM registry entry initialization fails, backends could try to
use an uninitialized DSM segment, DSA, or dshash table (since the
entry is still added to the registry). To fix, restructure the
code so that the registry retries initialization as needed. This
commit also modifies pg_get_dsm_registry_allocations() to leave out
partially-initialized entries, as they shouldn't have any allocated
memory.

DSM registry entry initialization shouldn't fail often in practice,
but retrying was deemed better than leaving entries in a
permanently failed state (as was done by commit 1165a933aa, which
has since been reverted).

Suggested-by: Robert Haas <robertmhaas(at)gmail(dot)com>
Reviewed-by: Robert Haas <robertmhaas(at)gmail(dot)com>
Discussion: https://postgr.es/m/E1vJHUk-006I7r-37%40gemulon.postgresql.org
Backpatch-through: 17

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b83bcc0df180056b9374bd4239d32fea84bb46f2

Modified Files
--------------
src/backend/storage/ipc/dsm_registry.c | 37 ++++++++++++++++++----------------
1 file changed, 20 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2025-11-26 21:21:13 Re: pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent
Previous Message Jeff Davis 2025-11-26 20:56:47 pgsql: Allow pg_locale_t APIs to work when ctype_is_c.