pgsql: Add assertions checking for the startup process in WAL replay ro

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add assertions checking for the startup process in WAL replay ro
Date: 2025-11-05 01:43:12
Message-ID: E1vGSYK-005519-2n@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add assertions checking for the startup process in WAL replay routines

These assertions may prove to become useful to make sure that no process
other than the startup process calls the routines where these checks are
added, as we expect that these do not interfere with a WAL receiver
switched to a "stopping" state by a startup process.

The assumption that only the startup process can use this code has
existed for many years, without a check enforcing it.

Reviewed-by: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
Discussion: https://postgr.es/m/aQmGeVLYl51y1m_0@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2fc31079624e16d6b1a8508958dbf81e8edce057

Modified Files
--------------
src/backend/access/transam/xlog.c | 2 ++
src/backend/access/transam/xlogrecovery.c | 4 ++++
2 files changed, 6 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Richard Guo 2025-11-05 03:30:05 pgsql: Fix comments for ChangeVarNodes() and related functions
Previous Message Andres Freund 2025-11-05 01:04:35 pgsql: aio: Improve assertions related to io_method