pgsql: aio: Improve assertions related to io_method

aio: Improve assertions related to io_method

First, the assertions in assign_io_method() were the wrong way round. Second,
the lengthof() assertion checked the length of io_method_options, which is the
wrong array to check and is always longer than pgaio_method_ops_table.

While add it, add a static assert to ensure pgaio_method_ops_table and
io_method_options stay in sync.

Per coverity and Tom Lane.

Reported-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dae00f333bdd98d094275080dba248cc80d4ca04

Modified Files
--------------
src/backend/storage/aio/aio.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)