pgsql: Tighten check for generated column in partition key expression

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Tighten check for generated column in partition key expression
Date: 2025-11-04 14:42:23
Message-ID: E1vGIEp-0050Jb-1K@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tighten check for generated column in partition key expression

A generated column may end up being part of the partition key
expression, if it's specified as an expression e.g. "(<generated
column name>)" or if the partition key expression contains a whole-row
reference, even though we do not allow a generated column to be part
of partition key expression. Fix this hole.

Co-authored-by: jian he <jian(dot)universality(at)gmail(dot)com>
Co-authored-by: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Reviewed-by: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/CACJufxF%3DWDGthXSAQr9thYUsfx_1_t9E6N8tE3B8EqXcVoVfQw%40mail.gmail.com

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7180d56c5609166ac9bd7203e7ac0ad50bf400ce

Modified Files
--------------
src/backend/commands/tablecmds.c | 86 ++++++++++++++++++---------------
src/test/regress/expected/generated.out | 15 ++++++
src/test/regress/sql/generated.sql | 3 ++
3 files changed, 66 insertions(+), 38 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Álvaro Herrera 2025-11-04 16:32:46 pgsql: Have psql's "\? variables" show csv_fieldsep
Previous Message Peter Eisentraut 2025-11-04 13:48:04 pgsql: Tighten check for generated column in partition key expression