pgsql: Tighten check for generated column in partition key expression

Tighten check for generated column in partition key expression

A generated column may end up being part of the partition key
expression, if it's specified as an expression e.g. "(<generated
column name>)" or if the partition key expression contains a whole-row
reference, even though we do not allow a generated column to be part
of partition key expression. Fix this hole.

Co-authored-by: jian he <jian(dot)universality(at)gmail(dot)com>
Co-authored-by: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Reviewed-by: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/CACJufxF%3DWDGthXSAQr9thYUsfx_1_t9E6N8tE3B8EqXcVoVfQw%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/040cc5f3c782839ed30816671c5b5f36df0d2398

Modified Files
--------------
src/backend/commands/tablecmds.c | 90 ++++++++++++++-----------
src/test/regress/expected/generated_stored.out | 15 +++++
src/test/regress/expected/generated_virtual.out | 15 +++++
src/test/regress/sql/generated_stored.sql | 3 +
src/test/regress/sql/generated_virtual.sql | 3 +
5 files changed, 86 insertions(+), 40 deletions(-)