pgsql: pg_restore: Fix comment handling with --no-publications / --no-s

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_restore: Fix comment handling with --no-publications / --no-s
Date: 2025-09-16 01:41:50
Message-ID: E1uyKhZ-000vKC-2S@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_restore: Fix comment handling with --no-publications / --no-subscriptions.

Previously, pg_restore did not skip comments on publications or subscriptions
even when --no-publications or --no-subscriptions was specified. As a result,
it could issue COMMENT commands for objects that were never created,
causing those commands to fail.

This commit fixes the issue by ensuring that comments on publications and
subscriptions are also skipped when the corresponding options are used.

Backpatch to all supported versions.

Author: Jian He <jian(dot)universality(at)gmail(dot)com>
Co-authored-by: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com
Backpatch-through: 13

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/97527a5e68d523048fd80aa1c97c3fe5bf948fb6

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 14 +++++++++++
src/bin/pg_dump/t/002_pg_dump.pl | 45 ++++++++++++++++++++++++++++++++++++
2 files changed, 59 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2025-09-16 01:42:10 pgsql: pg_restore: Fix comment handling with --no-publications / --no-s
Previous Message Fujii Masao 2025-09-16 01:41:38 pgsql: pg_restore: Fix comment handling with --no-publications / --no-s