From: | Fujii Masao <fujii(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: pg_restore: Fix comment handling with --no-publications / --no-s |
Date: | 2025-09-16 01:41:38 |
Message-ID: | E1uyKhN-000vJb-1U@gemulon.postgresql.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
pg_restore: Fix comment handling with --no-publications / --no-subscriptions.
Previously, pg_restore did not skip comments on publications or subscriptions
even when --no-publications or --no-subscriptions was specified. As a result,
it could issue COMMENT commands for objects that were never created,
causing those commands to fail.
This commit fixes the issue by ensuring that comments on publications and
subscriptions are also skipped when the corresponding options are used.
Backpatch to all supported versions.
Author: Jian He <jian(dot)universality(at)gmail(dot)com>
Co-authored-by: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com
Backpatch-through: 13
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f7f9c5d6581602d7bc264572753b6b95dc2173a8
Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 14 ++++++++++++
src/bin/pg_dump/t/002_pg_dump.pl | 41 ++++++++++++++++++++++++++++++++++++
2 files changed, 55 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2025-09-16 01:41:50 | pgsql: pg_restore: Fix comment handling with --no-publications / --no-s |
Previous Message | Fujii Masao | 2025-09-16 01:41:14 | pgsql: pg_restore: Fix comment handling with --no-publications / --no-s |