pgsql: pg_upgrade: Check for the expected error message in TAP tests.

pg_upgrade: Check for the expected error message in TAP tests.

Since pg_upgrade prints its error messages on stdout, we can't use
command_fails_like() to check if it fails for the right reason. This
commit uses command_checks_all() in pg_upgrade TAP tests to check the
exit status and stdout, enabling proper verification of error
reasons.

Author: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Discussion: https://postgr.es/m/87tt8h1vb7.fsf@wibble.ilmari.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f52345995d3691de7b0a888903b6cfed1497c672

Modified Files
--------------
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 5 ++++-
src/bin/pg_upgrade/t/004_subscription.pl | 7 ++++++-
src/bin/pg_upgrade/t/005_char_signedness.pl | 5 ++++-
3 files changed, 14 insertions(+), 3 deletions(-)