| From: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix ALTER TABLE error message |
| Date: | 2025-03-04 19:09:25 |
| Message-ID: | E1tpXdt-000n5L-1K@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix ALTER TABLE error message
This bogus error message was introduced in 2013 by commit f177cbfe676d,
because of misunderstanding the processCASbits() API; at the time, no
test cases were added that would be affected by this change. Only in
ca87c415e2fc was one added (along with a couple of typos), with an XXX
note that the error message was bogus. Fix the whole, add some test
cases.
Backpatch all the way back.
Reviewed-by: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Discussion: https://postgr.es/m/202503041822.aobpqke3igvb@alvherre.pgsql
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/931a1c0237901c68e6d57227fb1368178665c794
Modified Files
--------------
src/backend/parser/gram.y | 2 +-
src/test/regress/expected/foreign_key.out | 6 +++++-
src/test/regress/sql/foreign_key.sql | 4 +++-
3 files changed, 9 insertions(+), 3 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2025-03-04 19:16:30 | pgsql: pg_upgrade: Check for the expected error message in TAP tests. |
| Previous Message | Masahiko Sawada | 2025-03-04 18:41:04 | pgsql: Refactor Copy{From|To}GetRoutine() to use pass-by-reference argu |