| From: | Amit Kapila <akapila(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Raise a WARNING for max_slot_wal_keep_size in pg_createsubscribe |
| Date: | 2025-02-18 06:59:44 |
| Message-ID: | E1tkHa4-007klT-2l@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Raise a WARNING for max_slot_wal_keep_size in pg_createsubscriber.
During the pg_createsubscriber execution, it is possible that the required
WAL is removed from the primary/publisher node due to
'max_slot_wal_keep_size'.
This patch raises a WARNING during the '--dry-run' mode if the
'max_slot_wal_keep_size' is set to a non-default value on the
primary/publisher node.
Author: Shubham Khanna <khannashubham1197(at)gmail(dot)com>
Reviewed-by: Peter Smith <smithpb2250(at)gmail(dot)com>
Reviewed-by: Hayato Kuroda <kuroda(dot)hayato(at)fujitsu(dot)com>
Reviewed-by: Vignesh C <vignesh21(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAHv8Rj+deqsQXOMa7Tck8CBQUbsua=+4AuMVQ2=MPM0f-ZHbjA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/217919dd0954f54402e8d0a38cd203a740754077
Modified Files
--------------
doc/src/sgml/ref/pg_createsubscriber.sgml | 7 +++++++
src/bin/pg_basebackup/pg_createsubscriber.c | 20 +++++++++++++++++++-
2 files changed, 26 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-02-18 11:42:40 | pgsql: Fix poorly written regression test |
| Previous Message | John Naylor | 2025-02-18 04:05:26 | pgsql: Specialize intarray sorting |