From: | John Naylor <john(dot)naylor(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Specialize intarray sorting |
Date: | 2025-02-18 04:05:26 |
Message-ID: | E1tkErO-007jHf-1L@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Specialize intarray sorting
There is at least one report in the field of storing millions of
integers in arrays, so it seems like a good time to specialize
intarray's qsort function. In doing so, streamline the comparators:
Previously there were three, two for each direction for sorting
and one passed to qunique_arg. To preserve the early exit in the
case of descending input, pass the direction as an argument to
the comparator. This requires giving up duplicate detection, which
previously allowed skipping the qunique_arg() call. Testing showed
no regressions this way.
In passing, get rid of nearby checks that the input has at least
two elements, since preserving them would make some macros less
readable. These are not necessary for correctness, and seem like
premature optimizations.
Author: Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru>
Discussion: https://postgr.es/m/098A3E67-E4A6-4086-9C66-B1EAEB1DFE1C@yandex-team.ru
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/53d3daa491be458e543dd5bf24d40595e588e4e7
Modified Files
--------------
contrib/intarray/_int.h | 20 ++++++--------
contrib/intarray/_int_tool.c | 62 +++++++++++++++++++-------------------------
2 files changed, 34 insertions(+), 48 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2025-02-18 06:59:44 | pgsql: Raise a WARNING for max_slot_wal_keep_size in pg_createsubscribe |
Previous Message | Amit Kapila | 2025-02-18 03:59:13 | pgsql: Doc: Improve pg_replication_slots.inactive_since description. |