pgsql: Fix incorrect error message for IDENTIFY_SYSTEM

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix incorrect error message for IDENTIFY_SYSTEM
Date: 2023-12-05 13:38:12
Message-ID: E1rAVcq-008idJ-AL@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix incorrect error message for IDENTIFY_SYSTEM

Commit 5a991ef8692e accidentally reversed the order of the tuples
and fields parameters, making the error message incorrectly refer
to 3 tuples with 1 field when IDENTIFY_SYSTEM returns 1 tuple and
3 or 4 fields. Fix by changing the order of the parameters. This
also adds a comment describing why we check for < 3 when postgres
since 9.4 has been sending 4 fields.

Backpatch all the way since the bug is almost a decade old.

Author: Tomonari Katsumata <t(dot)katsumata1122(at)gmail(dot)com>
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Bug: #18224
Backpatch-through: v12

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b608afe980a5dfe91d76148900179d52d4db5e64

Modified Files
--------------
src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-12-05 15:02:14 pgsql: Fix indentation
Previous Message Daniel Gustafsson 2023-12-05 13:38:01 pgsql: Fix incorrect error message for IDENTIFY_SYSTEM