From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix incorrect error message for IDENTIFY_SYSTEM |
Date: | 2023-12-05 13:38:01 |
Message-ID: | E1rAVce-008icg-Hx@gemulon.postgresql.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix incorrect error message for IDENTIFY_SYSTEM
Commit 5a991ef8692e accidentally reversed the order of the tuples
and fields parameters, making the error message incorrectly refer
to 3 tuples with 1 field when IDENTIFY_SYSTEM returns 1 tuple and
3 or 4 fields. Fix by changing the order of the parameters. This
also adds a comment describing why we check for < 3 when postgres
since 9.4 has been sending 4 fields.
Backpatch all the way since the bug is almost a decade old.
Author: Tomonari Katsumata <t(dot)katsumata1122(at)gmail(dot)com>
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Bug: #18224
Backpatch-through: v12
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/1ce2986795eb6ac4de32da835087ea1d486fbfa3
Modified Files
--------------
src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2023-12-05 13:38:12 | pgsql: Fix incorrect error message for IDENTIFY_SYSTEM |
Previous Message | Daniel Gustafsson | 2023-12-05 13:37:50 | pgsql: Fix incorrect error message for IDENTIFY_SYSTEM |