pgsql: mingw: Define PGDLLEXPORT as __declspec (dllexport) as done for

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: mingw: Define PGDLLEXPORT as __declspec (dllexport) as done for
Date: 2022-09-30 17:50:41
Message-ID: E1oeK9o-000Jn2-TZ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

mingw: Define PGDLLEXPORT as __declspec (dllexport) as done for msvc

While mingw would otherwise fall back to
__attribute__((visibility("default"))), that appears to only work as long as
no symbols are declared with __declspec(dllexport). But we can end up with
some, e.g. plpython's Py_Init.

It's quite possible we should do the same for cygwin, but I don't have a test
environment for that...

Discussion: http://postgr.es/m/20220928022724.erzuk5v4ai4b53do@awork3.anarazel.de
Discussion: http://postgr.es/m/20220928025242.ugf7t5ugxxgmkraa@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0e497eadb1f4028b147b5c58dc08cea7e73675e1

Modified Files
--------------
src/include/port/win32.h | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Jaime Casanova 2022-09-30 20:44:22 Re: pgsql: Avoid improbable PANIC during heap_update.
Previous Message Tom Lane 2022-09-30 14:26:53 pgsql: Adjust PQsslAttributeNames() to match PQsslAttribute().