pgsql: Adjust PQsslAttributeNames() to match PQsslAttribute().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Adjust PQsslAttributeNames() to match PQsslAttribute().
Date: 2022-09-30 14:26:53
Message-ID: E1oeGya-000IWI-Q5@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Adjust PQsslAttributeNames() to match PQsslAttribute().

Currently, PQsslAttributeNames() returns the same list of attribute
names regardless of its conn parameter. This patch changes it to
have behavior parallel to what 80a05679d installed for PQsslAttribute:
you get OpenSSL's attributes if conn is NULL or is an SSL-encrypted
connection, or an empty list if conn is a non-encrypted connection.
The point of this is to have sensible connection-dependent behavior
in case we ever support multiple SSL libraries. The behavior for
NULL can be defined as "the attributes for the default SSL library",
parallel to what PQsslAttribute(NULL, "library") does.

Since this is mostly just future-proofing, no back-patch.

Discussion: https://postgr.es/m/17625-fc47c78b7d71b534@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4e4f7b9fcc9ad0b023b6e698e978882d022b94c4

Modified Files
--------------
doc/src/sgml/libpq.sgml | 12 +++++++++++-
src/interfaces/libpq/fe-secure-openssl.c | 15 +++++++++++++--
2 files changed, 24 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2022-09-30 17:50:41 pgsql: mingw: Define PGDLLEXPORT as __declspec (dllexport) as done for
Previous Message Alvaro Herrera 2022-09-30 10:55:53 pgsql: Fix tab-completion after commit 790bf615ddba