pgsql: Be more careful to avoid including system headers after perl.h

From: John Naylor <john(dot)naylor(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Be more careful to avoid including system headers after perl.h
Date: 2022-08-27 07:46:07
Message-ID: E1oRqW7-0006ij-6V@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Be more careful to avoid including system headers after perl.h

Commit 121d2d3d70 included simd.h into pg_wchar.h. This caused a problem
on Windows, since Perl has "#define free" (referring to globals), which
breaks the Windows' header. To fix, move the static inline function
definitions from plperl_helpers.h, into plperl.h, where we already
document the necessary inclusion order. Since those functions were the
only reason for the existence of plperl_helpers.h, remove it.

First reported by Justin Pryzby

Diagnosis and review by Andres Freund, patch by myself per suggestion
from Tom Lane

Discussion: https://www.postgresql.org/message-id/20220826115546.GE2342%40telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4eec2e03c34f9a357d86317b1cd05d80a2ab559d

Modified Files
--------------
contrib/hstore_plperl/hstore_plperl.c | 1 -
contrib/jsonb_plperl/jsonb_plperl.c | 1 -
src/pl/plperl/GNUmakefile | 4 +-
src/pl/plperl/SPI.xs | 1 -
src/pl/plperl/Util.xs | 1 -
src/pl/plperl/plperl.c | 2 -
src/pl/plperl/plperl.h | 170 ++++++++++++++++++++++++++++++++-
src/pl/plperl/plperl_helpers.h | 171 ----------------------------------
8 files changed, 171 insertions(+), 180 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Justin Pryzby 2022-08-27 11:23:04 Re: pgsql: Remove unnecessary casts in free() and pfree()
Previous Message Michael Paquier 2022-08-27 06:23:36 pgsql: Use correct connection for cancellation in frontend's parallel s