Re: pgsql: Remove unnecessary casts in free() and pfree()

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove unnecessary casts in free() and pfree()
Date: 2022-08-27 11:23:04
Message-ID: 20220827112304.GL2342@telsasoft.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Aug 26, 2022 at 02:02:33PM +0000, Peter Eisentraut wrote:
> Remove unnecessary casts in free() and pfree()

This seems to be breaking cfbot's "warnings" test.

[07:49:48.983] label.c:665:10: error: passing argument 1 of ‘pfree’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
[07:49:48.983] 665 | pfree(temp);

I imagine it would've been reported earlier, except that this commit was within
60min of the commit that broke perl.

--
Justin

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2022-08-27 11:52:05 pgsql: Fix typo in comment for writetuple() function
Previous Message John Naylor 2022-08-27 07:46:07 pgsql: Be more careful to avoid including system headers after perl.h