pgsql: Fix cache look-up failures while applying changes in logical rep

From: Amit Kapila <akapila(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix cache look-up failures while applying changes in logical rep
Date: 2022-06-15 05:03:50
Message-ID: E1o1LC2-0007hp-Mb@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix cache look-up failures while applying changes in logical replication.

While building a new attrmap which maps partition attribute numbers to
remoterel's, we incorrectly update the map for dropped column attributes.
Later, it caused cache look-up failure when we tried to use the map to
fetch the information about attributes.

This also fixes the partition map cache invalidation which was using the
wrong type cast to fetch the entry. We were using stale partition map
entry after invalidation which leads to the assertion or cache look-up
failure.

Reported-by: Shi Yu
Author: Hou Zhijie, Shi Yu
Reviewed-by: Amit Langote, Amit Kapila
Backpatch-through: 13, where it was introduced
Discussion: https://postgr.es/m/OSZPR01MB6310F46CD425A967E4AEF736FDA49@OSZPR01MB6310.jpnprd01.prod.outlook.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d457cb4e8a5e25fe16420cb91cb8450d8fca49d3

Modified Files
--------------
src/backend/replication/logical/relation.c | 62 ++++++++++++++++++------------
src/test/subscription/t/013_partition.pl | 58 +++++++++++++++++++++++++---
2 files changed, 90 insertions(+), 30 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-06-15 06:41:34 pgsql: Re-add locally-generated files in pg_upgrade's .gitignore and Ma
Previous Message Michael Paquier 2022-06-15 02:26:18 pgsql: Tweak behavior of psql --single-transaction depending on ON_ERRO