pgsql: Re-add locally-generated files in pg_upgrade's .gitignore and Ma

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Re-add locally-generated files in pg_upgrade's .gitignore and Ma
Date: 2022-06-15 06:41:34
Message-ID: E1o1Mic-0008RL-Bz@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Re-add locally-generated files in pg_upgrade's .gitignore and Makefile

This reverts the changes to pg_upgrade's Makefile and .gitignore done in
15b6d21. The TAP tests run in isolation, executing pg_upgrade in
tmp_check/ in the build directory so as any files created in the
execution path (reindex_hash.sql and delete_old_cluster.{sh,bat}) are
never in the tree, so entries are not necessary in this case. However,
not having these impacts the cleanliness of the code tree when running
./pg_upgrade directly from src/bin/pg_upgrade/.

This commit adds back to .gitignore all the files generated in the
execution path, and the Makefile rule to clean them up if they exist.

Per gripe from Tom Lane.

Discussion: https://postgr.es/m/90595.1655227384@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a059e15cdeef3e8de9a34de48c49c29d398bf4e8

Modified Files
--------------
src/bin/pg_upgrade/.gitignore | 4 ++++
src/bin/pg_upgrade/Makefile | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2022-06-15 15:01:57 pgsql: Link to MVCC docs in MERGE docs
Previous Message Amit Kapila 2022-06-15 05:03:50 pgsql: Fix cache look-up failures while applying changes in logical rep