pgsql: Allow db.schema.table patterns, but complain about random garbag

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Allow db.schema.table patterns, but complain about random garbag
Date: 2022-04-20 15:52:12
Message-ID: E1nhCcm-000HvW-AT@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Allow db.schema.table patterns, but complain about random garbage.

psql, pg_dump, and pg_amcheck share code to process object name
patterns like 'foo*.bar*' to match all tables with names starting in
'bar' that are in schemas starting with 'foo'. Before v14, any number
of extra name parts were silently ignored, so a command line '\d
foo.bar.baz.bletch.quux' was interpreted as '\d bletch.quux'. In v14,
as a result of commit 2c8726c4b0a496608919d1f78a5abc8c9b6e0868, we
instead treated this as a request for table quux in a schema named
'foo.bar.baz.bletch'. That caused problems for people like Justin
Pryzby who were accustomed to copying strings of the form
db.schema.table from messages generated by PostgreSQL itself and using
them as arguments to \d.

Accordingly, revise things so that if an object name pattern contains
more parts than we're expecting, we throw an error, unless there's
exactly one extra part and it matches the current database name.
That way, thisdb.myschema.mytable is accepted as meaning just
myschema.mytable, but otherdb.myschema.mytable is an error, and so
is some.random.garbage.myschema.mytable.

Mark Dilger, per report from Justin Pryzby and discussion among
various people.

Discussion: https://www.postgresql.org/message-id/20211013165426.GD27491%40telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d2d35479796c3510e249d6fc72adbd5df918efbf

Modified Files
--------------
doc/src/sgml/ref/psql-ref.sgml | 17 +-
src/bin/pg_amcheck/pg_amcheck.c | 27 +-
src/bin/pg_amcheck/t/002_nonesuch.pl | 99 ++++-
src/bin/pg_dump/pg_dump.c | 65 ++-
src/bin/pg_dump/pg_dumpall.c | 13 +-
src/bin/pg_dump/t/002_pg_dump.pl | 107 +++++
src/bin/psql/describe.c | 504 ++++++++++++++--------
src/fe_utils/string_utils.c | 129 ++++--
src/include/fe_utils/string_utils.h | 6 +-
src/test/regress/expected/psql.out | 804 +++++++++++++++++++++++++++++++++++
src/test/regress/sql/psql.sql | 242 +++++++++++
11 files changed, 1796 insertions(+), 217 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-04-20 22:08:37 pgsql: Disallow infinite endpoints in generate_series() for timestamps.
Previous Message Tom Lane 2022-04-20 15:18:55 Re: pgsql: Fix some trailing whitespace in documentation files

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-04-20 15:54:52 Re: pg14 psql broke \d datname.nspname.relname
Previous Message Tyler Brock 2022-04-20 15:30:51 Re: Are OIDs for pg_types constant?