pgsql: Remove dead code in do_pg_backup_start().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove dead code in do_pg_backup_start().
Date: 2022-04-11 19:56:14
Message-ID: E1ne090-0004Ts-MP@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove dead code in do_pg_backup_start().

As of commit 39969e2a1, no caller of do_pg_backup_start() passes NULL
for labelfile or tblspcmapfile, nor is it plausible that any would
do so in the future. Remove the code that coped with that case,
as (a) it's dead and (b) it causes Coverity to bleat about possibly
leaked storage.

While here, do some janitorial work on the function's header comment.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9de692c10176e2af00dc915b122e07bd6903185c

Modified Files
--------------
src/backend/access/transam/xlog.c | 30 +++++++++++++-----------------
1 file changed, 13 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2022-04-11 21:21:37 pgsql: Remove comment about historic heap vacuuming issue.
Previous Message Markus Wanner 2022-04-11 19:45:59 Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.]