From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Reject change of output-column collation in CREATE OR REPLACE VI |
Date: | 2022-02-15 17:57:50 |
Message-ID: | E1nK25G-0008Qn-71@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Reject change of output-column collation in CREATE OR REPLACE VIEW.
checkViewTupleDesc() didn't get the memo that it should verify
same attcollation along with same type/typmod. (A quick scan
did not find other similar oversights.)
Per bug #17404 from Pierre-Aurélien Georges. On another day
I might've back-patched this, but today I'm feeling paranoid
about unnecessary behavioral changes in back branches.
Discussion: https://postgr.es/m/17404-8a4a270ef30a6709@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/2523928b285b06242e0c669fadfc76d73bafdd66
Modified Files
--------------
src/backend/commands/view.c | 20 ++++++++++++++++--
src/test/regress/expected/create_view.out | 34 +++++++++++++++++++------------
src/test/regress/sql/create_view.sql | 25 +++++++++++++++--------
3 files changed, 56 insertions(+), 23 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-02-15 18:34:29 | Re: pgsql: Track LLVM 15 changes. |
Previous Message | Tom Lane | 2022-02-15 17:21:40 | pgsql: Improve subscriber's error message for wrong publication relkind |