pgsql: Don't use O_SYNC or similar when opening signal file to fsync it

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Don't use O_SYNC or similar when opening signal file to fsync it
Date: 2021-07-31 07:11:13
Message-ID: E1m9j9N-0005tZ-FN@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't use O_SYNC or similar when opening signal file to fsync it.

No need to use get_sync_bit() when we're calling pg_fsync() on the file.
We're not writing to the files, so it doesn't make any difference in
practice, but seems less surprising this way.

Reviewed-by: Andres Freund
Discussion: https://www.postgresql.org/message-id/b3b71061-4919-e882-4857-27e370ab134a%40iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e9f5a0681cb9cf74b4c1c98e10182ccce04aa08c

Modified Files
--------------
src/backend/access/transam/xlog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Dean Rasheed 2021-07-31 10:35:43 pgsql: Fix corner-case errors and loss of precision in numeric_power().
Previous Message Amit Kapila 2021-07-31 04:41:49 Re: pgsql: Add support for prepared transactions to built-in logical replic