Re: pgsql: Add support for prepared transactions to built-in logical replic

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Amit Kapila <akapila(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add support for prepared transactions to built-in logical replic
Date: 2021-07-31 04:41:49
Message-ID: CAA4eK1KYE-ACRP8JQ0O4QnPb97iJx8m6-jfUTGiDVKrZBL9SfQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Jul 30, 2021 at 6:17 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> Hi Amit,
>
> On Wed, Jul 14, 2021 at 02:41:43AM +0000, Amit Kapila wrote:
> > Add support for prepared transactions to built-in logical replication.
>
> 021_twophase.pl, that has been introdeuced in this commit, is proving
> to be a bit unstable:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=idiacanthus&dt=2021-07-30%2009%3A56%3A04
> # Failed test 'transaction is prepared on subscriber'
> # at t/021_twophase.pl line 324.
> # got: '1'
> # expected: '2'
> # Looks like you failed 1 test of 24.
> [12:14:02] t/021_twophase.pl ..................
>

Thanks for the report. I have shared my initial analysis in the
corresponding -hackers thread [1].

[1] - https://www.postgresql.org/message-id/CAA4eK1%2B_0iNQ8Z%3DKVTjmmAqNX-hyv%2B1%2BfnZ-Yx8CVP%3DuAcekqw%40mail.gmail.com

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2021-07-31 07:11:13 pgsql: Don't use O_SYNC or similar when opening signal file to fsync it
Previous Message Michael Paquier 2021-07-31 01:32:53 Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows