| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix internal extract(timezone_minute) formulas |
| Date: | 2021-04-01 14:15:13 |
| Message-ID: | E1lRy6L-0001yM-Iy@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix internal extract(timezone_minute) formulas
Through various refactorings over time, the extract(timezone_minute
from time with time zone) and extract(timezone_minute from timestamp
with time zone) implementations ended up with two different but
equally nonsensical formulas by using SECS_PER_MINUTE and
MINS_PER_HOUR interchangeably. Since those two are of course both the
same number, the formulas do work, but for readability, fix them to be
semantically correct.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/91e7c903291116bd081abe7d4a058d40a2a06e16
Modified Files
--------------
src/backend/utils/adt/date.c | 2 +-
src/backend/utils/adt/timestamp.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-04-01 17:34:38 | pgsql: Fix pg_restore's misdesigned code for detecting archive file for |
| Previous Message | Alvaro Herrera | 2021-04-01 13:29:14 | pgsql: libpq_pipeline: Must strdup(optarg) to avoid crash |