pgsql: libpq_pipeline: Must strdup(optarg) to avoid crash

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: libpq_pipeline: Must strdup(optarg) to avoid crash
Date: 2021-04-01 13:29:14
Message-ID: E1lRxNq-0001ia-Eg@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

libpq_pipeline: Must strdup(optarg) to avoid crash

I forgot to strdup() when processing argv[]. Apparently many platforms
hide this mistake from users, but in those that don't you may get a
program crash. Repair.

Per buildfarm member drongo, which is the only one in all the buildfarm
manifesting a problem here.

While at it, move "numrows" processing out of the line of special cases,
and make it getopt's -r instead. (A similar thing could be done to
'conninfo', but current use of the program doesn't warrant spending time
on that -- nowhere else we use conninfo in so simplistic a manner.)

Discussion: https://postgr.es/m/20210401124850.GA19247@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dde1a35aee6266dc8105717275335c46cd2b3650

Modified Files
--------------
src/test/modules/libpq_pipeline/libpq_pipeline.c | 32 +++++++++++-----------
.../modules/libpq_pipeline/t/001_libpq_pipeline.pl | 5 ++--
2 files changed, 18 insertions(+), 19 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2021-04-01 14:15:13 pgsql: Fix internal extract(timezone_minute) formulas
Previous Message Heikki Linnakangas 2021-04-01 09:25:01 pgsql: Do COPY FROM encoding conversion/verification in larger chunks.