pgsql: Make new authentication test case more robust.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Make new authentication test case more robust.
Date: 2020-09-05 01:02:15
Message-ID: E1kEMat-0004Pe-Eq@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make new authentication test case more robust.

I happened to notice that the new test case I added in b55b4dad9
falls over if one runs "make check" repeatedly; though not in branches
after v10. That's because it was assuming that tmp_check/pgpass
wouldn't exist already. However, it's only been since v11 that the
Makefiles forcibly remove all of tmp_check/ before starting a TAP run.
This fix to unlink the file is therefore strictly necessary only in
v10 ... but it seems wisest to do it across the board, rather than
let the test rely on external logic to get the conditions right.

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8df601bd4067ecdf373ebe43bdf03159a12e2e9d

Modified Files
--------------
src/test/authentication/t/001_password.pl | 1 +
1 file changed, 1 insertion(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2020-09-05 04:56:04 pgsql: Use multi-inserts for pg_depend
Previous Message Tom Lane 2020-09-05 00:33:50 pgsql: Fix over-eager ping'ing in logical replication receiver.