pgsql: Fix over-eager ping'ing in logical replication receiver.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix over-eager ping'ing in logical replication receiver.
Date: 2020-09-05 00:33:50
Message-ID: E1kEM9O-0004E9-Pf@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix over-eager ping'ing in logical replication receiver.

Commit 3f60f690f only partially fixed the broken-status-tracking
issue in LogicalRepApplyLoop: we need ping_sent to have the same
lifetime as last_recv_timestamp. The effects are much less serious
than what that commit fixed, though. AFAICS this would just lead to
extra ping requests being sent, once per second until the sender
responds. Still, it's a bug, so backpatch to v10 as before.

Discussion: https://postgr.es/m/959627.1599248476@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c8746f999ea2feba22832b485fba37b5301b54a3

Modified Files
--------------
src/backend/replication/logical/worker.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-09-05 01:02:15 pgsql: Make new authentication test case more robust.
Previous Message Jeff Davis 2020-09-04 19:15:17 pgsql: Fix bogus MaxAllocSize check in logtape.c.