pgsql: Add prefix checks in exclude lists for pg_rewind, pg_checksums a

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add prefix checks in exclude lists for pg_rewind, pg_checksums a
Date: 2020-02-24 09:15:17
Message-ID: E1j69pd-0007mK-86@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add prefix checks in exclude lists for pg_rewind, pg_checksums and base backups

An instance of PostgreSQL crashing with a bad timing could leave behind
temporary pg_internal.init files, potentially causing failures when
verifying checksums. As the same exclusion lists are used between
pg_rewind, pg_checksums and basebackup.c, all those tools are extended
with prefix checks to keep everything in sync, with dedicated checks
added for pg_internal.init.

Backpatch down to 11, where pg_checksums (pg_verify_checksums in 11) and
checksum verification for base backups have been introduced.

Reported-by: Michael Banck
Author: Michael Paquier
Reviewed-by: Kyotaro Horiguchi, David Steele
Discussion: https://postgr.es/m/62031974fd8e941dd8351fbc8c7eff60d59c5338.camel@credativ.de
Backpatch-through: 11

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a8beece956ebf0659e64e229519f6e87b13b8b3a

Modified Files
--------------
src/backend/replication/basebackup.c | 75 ++++++++++++++++++----------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 8 +--
src/bin/pg_checksums/pg_checksums.c | 39 +++++++++++----
src/bin/pg_checksums/t/002_actions.pl | 4 +-
src/bin/pg_rewind/filemap.c | 43 +++++++++++-----
5 files changed, 116 insertions(+), 53 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2020-02-24 11:51:58 pgsql: Move bitmap_hash and bitmap_match to bitmapset.c.
Previous Message Thomas Munro 2020-02-24 06:53:34 Re: pgsql: Add kqueue(2) support to the WaitEventSet API.