From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Rémi Zara <remi_zara(at)mac(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: Add kqueue(2) support to the WaitEventSet API. |
Date: | 2020-02-24 06:53:34 |
Message-ID: | CA+hUKGJeL9XP8p5c4fGoAgPU9ktuxpiCt6An4N9ytO=qSh9WgA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Mon, Feb 24, 2020 at 7:42 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Mon, Feb 24, 2020 at 12:24 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > On reflection, trying to make ReserveExternalFD serve two different
> > use-cases was pretty messy. Here's a version that splits it into two
> > functions. I also took the trouble to fix dblink.
>
> + /*
> + * We don't want more than max_safe_fds / 3 FDs to be consumed for
> + * "external" FDs.
> + */
> + if (numExternalFDs < max_safe_fds / 3)
I suppose there may be users who have set ulimit -n high enough to
support an FDW workload that connects to very many hosts, who will now
need to set max_files_per_process higher to avoid the new error now
that we're doing this accounting. That doesn't seem to be a problem
in itself, but I wonder if the error message should make it clearer
that it's our limit they hit here.
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-02-24 09:15:17 | pgsql: Add prefix checks in exclude lists for pg_rewind, pg_checksums a |
Previous Message | Thomas Munro | 2020-02-24 06:42:52 | Re: pgsql: Add kqueue(2) support to the WaitEventSet API. |
From | Date | Subject | |
---|---|---|---|
Next Message | Aditya Toshniwal | 2020-02-24 06:59:06 | Re: PG v12.2 - Setting jit_above_cost is causing the server to crash |
Previous Message | Aditya Toshniwal | 2020-02-24 06:46:08 | PG v12.2 - Setting jit_above_cost is causing the server to crash |