pgAdmin 4 commit: Fix an issue where command and statements were parsed

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: pgadmin-hackers(at)lists(dot)postgresql(dot)org
Subject: pgAdmin 4 commit: Fix an issue where command and statements were parsed
Date: 2020-02-24 06:41:53
Message-ID: E1j67RB-0001e7-CK@gothos.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Fix an issue where command and statements were parsed incorrectly for Rules. Fixes #5115

Fixed issue where removing command or statements altogether was not generating modified SQL.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a44f17a2fcdca20611fdaea0cb1e8b633e4e81bc
Author: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>

Modified Files
--------------
docs/en_US/release_notes_4_19.rst | 3 +-
.../schemas/tables/rules/static/js/rule.js | 8 ++--
.../tests/default/alter_delete_event_rule.sql | 4 +-
.../tests/default/alter_delete_event_rule_msql.sql | 4 +-
.../tests/default/alter_insert_event_rule.sql | 6 +--
.../default/alter_insert_event_rule_complex.sql | 17 +++++++
.../alter_insert_event_rule_complex_msql.sql | 8 ++++
.../tests/default/alter_insert_event_rule_msql.sql | 6 +--
.../tests/default/alter_update_event_rule.sql | 6 +--
.../tests/default/alter_update_event_rule_msql.sql | 6 +--
.../tests/default/create_delete_event_rule.sql | 3 +-
.../default/create_delete_event_rule_msql.sql | 3 +-
.../tests/default/create_insert_event_rule.sql | 6 +--
.../default/create_insert_event_rule_msql.sql | 6 +--
.../tests/default/create_update_event_rule.sql | 6 +--
.../default/create_update_event_rule_msql.sql | 6 +--
.../schemas/tables/rules/tests/default/test.json | 11 +++++
.../schemas/tables/templates/rules/sql/create.sql | 16 +++----
.../tables/templates/rules/sql/properties.sql | 4 +-
.../schemas/tables/templates/rules/sql/update.sql | 16 ++++---
.../servers/databases/schemas/utils.py | 53 +++++++++++++---------
21 files changed, 124 insertions(+), 74 deletions(-)

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-02-24 06:42:18 Re: [pgAdmin][RM5115] RULE SQL incorrectly generated
Previous Message Peter J. Holzer 2020-02-23 10:19:28 Re: DB running out of memory issues after upgrade