| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][RM5115] RULE SQL incorrectly generated |
| Date: | 2020-02-24 06:42:18 |
| Message-ID: | CANxoLDePRTHLUbavZnFALsw7Ny8hBKLAbAX8X_tmjBA1KD0MaA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, patch applied.
On Fri, Feb 21, 2020 at 3:10 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached is the patch to fix the SQL parsing issue in rules. The command
> and statements were parsed incorrectly.
> Also fixed issue where removing command or statements altogether was not
> generating modified SQL and so was not saving.
> Test cases added and changed accordingly.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2020-02-24 07:03:31 | pgAdmin 4 commit: Ensure that AlertifyJS should not be visible as a tit |
| Previous Message | Akshay Joshi | 2020-02-24 06:41:53 | pgAdmin 4 commit: Fix an issue where command and statements were parsed |