pgsql: Prevent running pg_basebackup as root

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Prevent running pg_basebackup as root
Date: 2020-02-01 09:33:20
Message-ID: E1ixp9U-0005XS-59@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Prevent running pg_basebackup as root

Similarly to pg_upgrade, pg_ctl and initdb, a root user is able to use
--version and --help, but cannot execute the actual operation to avoid
the creation of files with permissions incompatible with the
postmaster.

This is a behavior change, so not back-patching is done.

Author: Ian Barwick
Discussion: https://postgr.es/m/CABvVfJVqOdD2neLkYdygdOHvbWz_5K_iWiqY+psMfA=FeAa3qQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7bae0ad9fcb76b28410571dc71edfdc3175c4a02

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2020-02-01 09:36:53 Re: pgsql: Fix memory leak on DSM slot exhaustion.
Previous Message Thomas Munro 2020-02-01 02:36:09 pgsql: Fix memory leak on DSM slot exhaustion.

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-02-01 09:34:33 Re: Prevent pg_basebackup running as root
Previous Message Dent John 2020-02-01 09:09:32 Re: The flinfo->fn_extra question, from me this time.