Re: pgsql: Fix memory leak on DSM slot exhaustion.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Thomas Munro <tmunro(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix memory leak on DSM slot exhaustion.
Date: 2020-02-01 09:36:53
Message-ID: 20200201093653.GB4133@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi Thomas,

On Sat, Feb 01, 2020 at 02:33:42AM +0000, Thomas Munro wrote:
> Fix memory leak on DSM slot exhaustion.
>
> If we attempt to create a DSM segment when no slots are available,
> we should return the memory to the operating system. Previously
> we did that if the DSM_CREATE_NULL_IF_MAXSEGMENTS flag was
> passed in, but we didn't do it if an error was raised. Repair.
>
> Back-patch to 9.4, where DSM segments arrived.

It seems to me that you have forgotten REL_11_STABLE in the set of
branches to fix.

Thanks,
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2020-02-01 10:01:01 pgsql: Fix memory leak on DSM slot exhaustion.
Previous Message Michael Paquier 2020-02-01 09:33:20 pgsql: Prevent running pg_basebackup as root