pgsql: Skip system attributes when applying mvdistinct stats

From: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Skip system attributes when applying mvdistinct stats
Date: 2019-11-16 01:34:08
Message-ID: E1iVmyW-0002aF-AR@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Skip system attributes when applying mvdistinct stats

When estimating number of distinct groups, we failed to ignore system
attributes when matching the group expressions to mvdistinct stats,
causing failures like

ERROR: negative bitmapset member not allowed

Fix that by simply skipping anything that is not a regular attribute.
Backpatch to PostgreSQL 10, where the extended stats were introduced.

Bug: #16111
Reported-by: Tuomas Leikola
Author: Tomas Vondra
Backpatch-through: 10
Discussion: https://postgr.es/m/16111-687799584c3a7e73@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d482f7f867b58bbd29f65a4471eca8c5b57a7da0

Modified Files
--------------
src/backend/utils/adt/selfuncs.c | 19 ++++++++++++++-----
src/test/regress/expected/stats_ext.out | 7 +++++++
src/test/regress/sql/stats_ext.sql | 3 +++
3 files changed, 24 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tomas Vondra 2019-11-16 01:34:19 pgsql: Skip system attributes when applying mvdistinct stats
Previous Message Thomas Munro 2019-11-15 21:31:10 pgsql: Always call ExecShutdownNode() if appropriate.