| From: | Thomas Munro <tmunro(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Always call ExecShutdownNode() if appropriate. |
| Date: | 2019-11-15 21:31:10 |
| Message-ID: | E1iVjBO-0001Yq-46@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Always call ExecShutdownNode() if appropriate.
Call ExecShutdownNode() after ExecutePlan()'s loop, rather than at each
break. We had forgotten to do that in one case. The omission caused
intermittent "temporary file leak" warnings from multi-batch parallel
hash joins with a LIMIT clause.
Back-patch to 11. Though the problem exists in theory in earlier
parallel query releases, nothing really depended on it.
Author: Kyotaro Horiguchi
Reviewed-by: Thomas Munro, Amit Kapila
Discussion: https://postgr.es/m/20191111.212418.2222262873417235945.horikyota.ntt%40gmail.com
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/bc049d0d460aead528ace909a3477bc701ab2e9a
Modified Files
--------------
src/backend/executor/execMain.c | 23 +++++++----------------
1 file changed, 7 insertions(+), 16 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2019-11-16 01:34:08 | pgsql: Skip system attributes when applying mvdistinct stats |
| Previous Message | Thomas Munro | 2019-11-15 21:30:46 | pgsql: Always call ExecShutdownNode() if appropriate. |