From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Simplify TAP tests of pg_dump for connection strings |
Date: | 2019-07-04 02:35:06 |
Message-ID: | E1hiraU-0000ZX-VE@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Simplify TAP tests of pg_dump for connection strings
The last set of scenarios did an initialization of nodes followed by an
extra command to set up the authentication policy with pg_regress
--config-auth. This configuration step can be integrated directly using
the option auth_extra from PostgresNode::init when initializing the
node, saving from one extra command. On Windows, this also restricts
more pg_ident.conf for the SSPI user mapping by removing the entry of
the OS user running the test, which is not needed anyway.
Note that IPC::Run mishandles double quotes, hence the restore user name
is changed to map with that. This was already done in the test as a
later step, but not in a consistent way, causing the switch to use
auth_extra to fail.
Found while reviewing ca129e5.
Discussion: https://postgr.es/m/20190703062024.GD3084@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d5ab9a891cb590aad4278026b2edda685f2524a2
Modified Files
--------------
src/bin/pg_dump/t/010_dump_connstr.pl | 32 ++++++++++++--------------------
1 file changed, 12 insertions(+), 20 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Gierth | 2019-07-04 05:57:19 | Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.) |
Previous Message | David Rowley | 2019-07-04 01:01:33 | pgsql: Use appendStringInfoString and appendPQExpBufferStr where possib |