pgsql: Use appendStringInfoString and appendPQExpBufferStr where possib

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Use appendStringInfoString and appendPQExpBufferStr where possib
Date: 2019-07-04 01:01:33
Message-ID: E1hiq7x-0008H8-Fu@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Use appendStringInfoString and appendPQExpBufferStr where possible

This changes various places where appendPQExpBuffer was used in places
where it was possible to use appendPQExpBufferStr, and likewise for
appendStringInfo and appendStringInfoString. This is really just a
stylistic improvement, but there are also small performance gains to be
had from doing this.

Discussion: http://postgr.es/m/CAKJS1f9P=M-3ULmPvr8iCno8yvfDViHibJjpriHU8+SXUgeZ=w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8abc13a88938ef473b8a486186f1b96630450728

Modified Files
--------------
contrib/postgres_fdw/deparse.c | 8 +-
contrib/sepgsql/database.c | 6 +-
contrib/sepgsql/label.c | 2 +-
contrib/sepgsql/selinux.c | 2 +-
contrib/test_decoding/test_decoding.c | 4 +-
src/backend/access/rmgrdesc/heapdesc.c | 4 +-
src/backend/commands/explain.c | 2 +-
src/backend/utils/adt/ruleutils.c | 2 +-
src/bin/pg_basebackup/streamutil.c | 8 +-
src/bin/pg_ctl/pg_ctl.c | 4 +-
src/bin/pg_dump/dumputils.c | 4 +-
src/bin/pg_dump/pg_backup_archiver.c | 6 +-
src/bin/pg_dump/pg_backup_db.c | 2 +-
src/bin/pg_dump/pg_dump.c | 158 ++++++++++++++++-----------------
src/bin/pg_dump/pg_dumpall.c | 4 +-
src/bin/pg_upgrade/dump.c | 2 +-
src/bin/psql/command.c | 4 +-
src/bin/psql/describe.c | 94 ++++++++++----------
src/bin/scripts/clusterdb.c | 2 +-
src/bin/scripts/reindexdb.c | 2 +-
src/bin/scripts/vacuumdb.c | 44 ++++-----
src/fe_utils/string_utils.c | 4 +-
src/interfaces/libpq/fe-auth-scram.c | 14 +--
src/interfaces/libpq/fe-connect.c | 4 +-
src/interfaces/libpq/fe-protocol3.c | 4 +-
25 files changed, 195 insertions(+), 195 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-07-04 02:35:06 pgsql: Simplify TAP tests of pg_dump for connection strings
Previous Message Tom Lane 2019-07-03 22:09:01 pgsql: Ensure plpgsql result tuples have the right composite type marki