pgsql: Fix program build rule in src/bin/scripts/Makefile.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix program build rule in src/bin/scripts/Makefile.
Date: 2019-01-05 00:12:28
Message-ID: E1gfZZk-0007tI-0R@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix program build rule in src/bin/scripts/Makefile.

Commit 69ae9dcb4 added a globally-visible "%: %.o" rule, but we failed
to notice that src/bin/scripts/Makefile already had such a rule.
Apparently, the later occurrence of the same rule wins in nearly all
versions of gmake ... but not in the one used by buildfarm member jacana.
jacana is evidently using the global rule, which says to link "$<",
ie just the first dependency. But the scripts makefile needs to
link "$^", ie all the dependencies listed for the target.

There is, fortunately, no good reason not to use "$^" in the global
version of the rule, so we can just do that and get rid of the local
version.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c5c7fa261f57fadd93f166dc33ce2b1d188ad4e7

Modified Files
--------------
src/Makefile.global.in | 2 +-
src/bin/scripts/Makefile | 19 ++++++++-----------
2 files changed, 9 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-01-05 03:50:23 pgsql: doc: Update RFC URLs
Previous Message Andres Freund 2019-01-04 20:39:26 Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.