| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility. |
| Date: | 2019-01-04 20:39:26 |
| Message-ID: | 20190104203926.evck47fge5ugjwh7@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2019-01-03 13:40:42 -0500, Tom Lane wrote:
> I noticed that this patch has broken restores of existing dump files:
>
> psql:testbed.public.backup:82: ERROR: unrecognized configuration parameter "default_with_oids"
>
> Quite aside from the fact that this won't work if the user tries to
> restore in single-transaction or no-error mode, this is really really
> unhelpful because it's impossible to tell whether the error is
> ignorable or not, except by digging through the dump file.
>
> What you should do is restore that GUC, but add a check-hook that throws
> an error for an attempt to set it to "true".
Makes sense, I (or a colleague) will look into that next week. Wanna get my
head out of pluggable storage first...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-01-05 00:12:28 | pgsql: Fix program build rule in src/bin/scripts/Makefile. |
| Previous Message | Alvaro Herrera | 2019-01-04 18:04:18 | pgsql: Don't create relfilenode for relations without storage |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2019-01-04 20:46:32 | Re: reducing the footprint of ScanKeyword (was Re: Large writable variables) |
| Previous Message | Tom Lane | 2019-01-04 20:36:21 | Re: reducing the footprint of ScanKeyword (was Re: Large writable variables) |