pgsql: Allow using the updated tuple while moving it to a different par

From: Amit Kapila <akapila(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Allow using the updated tuple while moving it to a different par
Date: 2018-07-12 07:33:54
Message-ID: E1fdW6s-00054K-QA@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Allow using the updated tuple while moving it to a different partition.

An update that causes the tuple to be moved to a different partition was
missing out on re-constructing the to-be-updated tuple, based on the latest
tuple in the update chain. Instead, it's simply deleting the latest tuple
and inserting a new tuple in the new partition based on the old tuple.
Commit 2f17844104 didn't consider this case, so some of the updates were
getting lost.

In passing, change the argument order for output parameter in ExecDelete
and add some commentary about it.

Reported-by: Pavan Deolasee
Author: Amit Khandekar, with minor changes by me
Reviewed-by: Dilip Kumar, Amit Kapila and Alvaro Herrera
Backpatch-through: 11
Discussion: https://postgr.es/m/CAJ3gD9fRbEzDqdeDq1jxqZUb47kJn+tQ7=Bcgjc8quqKsDViKQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/40ca70ebcc9d0bc1c02937b27c44b2766617e790

Modified Files
--------------
src/backend/commands/trigger.c | 22 ++++++-
src/backend/executor/execReplication.c | 2 +-
src/backend/executor/nodeModifyTable.c | 73 +++++++++++++++------
src/include/commands/trigger.h | 3 +-
.../isolation/expected/partition-key-update-4.out | 60 +++++++++++++++++
src/test/isolation/isolation_schedule | 1 +
.../isolation/specs/partition-key-update-4.spec | 76 ++++++++++++++++++++++
7 files changed, 214 insertions(+), 23 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-07-12 07:59:09 Re: pgsql: Allow using the updated tuple while moving it to a different par
Previous Message Michael Paquier 2018-07-12 05:29:37 pgsql: Rename VACOPT_NOWAIT to VACOPT_SKIP_LOCKED

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-07-12 07:44:45 Re: Temporary WAL segments files not cleaned up after an instance crash
Previous Message Yugo Nagata 2018-07-12 07:20:13 Re: [PG-11] Potential bug related to INCLUDE clause of CREATE INDEX