Re: pgsql: Allow using the updated tuple while moving it to a different par

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Amit Kapila <akapila(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Allow using the updated tuple while moving it to a different par
Date: 2018-07-12 07:59:09
Message-ID: 20180712075909.GG7352@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Jul 12, 2018 at 07:33:54AM +0000, Amit Kapila wrote:
> Allow using the updated tuple while moving it to a different partition.
>
> An update that causes the tuple to be moved to a different partition was
> missing out on re-constructing the to-be-updated tuple, based on the latest
> tuple in the update chain. Instead, it's simply deleting the latest tuple
> and inserting a new tuple in the new partition based on the old tuple.
> Commit 2f17844104 didn't consider this case, so some of the updates were
> getting lost.
>
> In passing, change the argument order for output parameter in ExecDelete
> and add some commentary about it.

Looks unrelated, but flaviventris (a snake?) has just complained:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=flaviventris&dt=2018-07-12%2007%3A36%3A01
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2018-07-12 11:14:28 Re: pgsql: Allow using the updated tuple while moving it to a different par
Previous Message Amit Kapila 2018-07-12 07:33:54 pgsql: Allow using the updated tuple while moving it to a different par

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2018-07-12 07:59:39 Problem on pg_dump RANGE partition with expressions
Previous Message Amit Kapila 2018-07-12 07:52:41 Re: In pageinspect, perform clean-up after testing gin-related functions