pgsql: Charge cpu_tuple_cost * 0.5 for Append and MergeAppend nodes.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Charge cpu_tuple_cost * 0.5 for Append and MergeAppend nodes.
Date: 2018-02-22 04:10:26
Message-ID: E1eoiDC-00083t-GD@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Charge cpu_tuple_cost * 0.5 for Append and MergeAppend nodes.

Previously, Append didn't charge anything at all, and MergeAppend
charged only cpu_operator_cost, about half the value used here. This
change might make MergeAppend plans slightly more likely to be chosen
than before, since this commit increases the assumed cost for Append
-- with default values -- by 0.005 per tuple but MergeAppend by only
0.0025 per tuple. Since the comparisons required by MergeAppend are
costed separately, it's not clear why MergeAppend needs to be
otherwise more expensive than Append, so hopefully this is OK.

Prior to partition-wise join, it didn't really matter whether or not
an Append node had any cost of its own, because every plan had to use
the same number of Append or MergeAppend nodes and in the same places.
Only the relative cost of Append vs. MergeAppend made a difference.
Now, however, it is possible to avoid some of the Append nodes using a
partition-wise join, so it's worth making an effort. Pending patches
for partition-wise aggregate care too, because an Append of Aggregate
nodes will incur the Append overhead fewer times than an Aggregate
over an Append. Although in most cases this change will favor the use
of partition-wise techniques, it does the opposite when the join
cardinality is greater than the sum of the input cardinalities. Since
this situation arises in an existing regression test, I [rhaas]
adjusted it to keep the overall plan shape approximately the same.

Jeevan Chalke, per a suggestion from David Rowley. Reviewed by
Ashutosh Bapat. Some changes by me. The larger patch series of which
this patch is a part was also reviewed and tested by Antonin Houska,
Rajkumar Raghuwanshi, David Rowley, Dilip Kumar, Konstantin Knizhnik,
Pascal Legrand, Rafia Sabih, and me.

Discussion: http://postgr.es/m/CAKJS1f9UXdk6ZYyqbJnjFO9a9hyHKGW7B=ZRh-rxy9qxfPA5Gw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7d8ac9814bc9bb6df2d845dbabed38d7284c7c2c

Modified Files
--------------
src/backend/optimizer/path/costsize.c | 26 +++--
src/test/regress/expected/partition_join.out | 136 +++++++++++++--------------
src/test/regress/expected/subselect.out | 4 +-
src/test/regress/sql/partition_join.sql | 8 +-
4 files changed, 91 insertions(+), 83 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-02-22 05:35:13 Re: pgsql: Charge cpu_tuple_cost * 0.5 for Append and MergeAppend nodes.
Previous Message Tom Lane 2018-02-21 23:40:43 pgsql: Repair pg_upgrade's failure to preserve relfrozenxid for matview

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-02-22 04:10:28 Re: [HACKERS] Partition-wise aggregation/grouping
Previous Message Craig Ringer 2018-02-22 03:25:17 Re: [bug fix] Produce a crash dump before main() on Windows