pgsql: Support --no-comments in pg_dump, pg_dumpall, pg_restore.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Support --no-comments in pg_dump, pg_dumpall, pg_restore.
Date: 2018-01-25 20:27:29
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Support --no-comments in pg_dump, pg_dumpall, pg_restore.

We have switches already to suppress other subsidiary object properties,
such as ACLs, security labels, ownership, and tablespaces, so just on
the grounds of symmetry we should allow suppressing comments as well.
Also, commit 0d4e6ed30 added a positive reason to have this feature,
i.e. to allow obtaining the old behavior of selective pg_restore should
anyone desire that.

Recent commits have removed the cases where pg_dump emitted comments on
built-in objects that the restoring user might not have privileges to
comment on, so the original primary motivation for this feature is gone,
but it still seems at least somewhat useful in its own right.

Robins Tharakan, reviewed by Fabrízio Mello




Modified Files
doc/src/sgml/ref/pg_dump.sgml | 9 +++++++++
doc/src/sgml/ref/pg_dumpall.sgml | 9 +++++++++
doc/src/sgml/ref/pg_restore.sgml | 9 +++++++++
src/bin/pg_dump/pg_backup.h | 2 ++
src/bin/pg_dump/pg_backup_archiver.c | 6 +++++-
src/bin/pg_dump/pg_dump.c | 19 +++++++++++++++++--
src/bin/pg_dump/pg_dumpall.c | 9 +++++++--
src/bin/pg_dump/pg_restore.c | 4 ++++
8 files changed, 62 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2018-01-25 20:34:15 Re: reducing isolation tests runtime
Previous Message Tom Lane 2018-01-25 19:32:34 pgsql: Add missing "static" markers.